Add ability to open URLs#1680
Open
The0Show wants to merge 5 commits into
Open
Conversation
qreeves
requested changes
Oct 13, 2025
qreeves
left a comment
qreeves
left a comment
Member
There was a problem hiding this comment.
Minor code style issues. No objections to other commands added.
BREAKING CHANGE: `/open_url` is now `/openurl` `/set_clipboard` is now `/setclipboard`
Author
|
Updated the initial comment with new command names. |
Author
|
I just realized I forgot to request a new review, sorry! |
Member
|
Looks good to me, will merge with the next sweep. |
qreeves
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1673
Tested on Arch Linux w/ KDE
Adds the
/openurl <s>command, which opens the given URL in the user's default browser.The command checks if the string begins with
http://orhttps://, and does nothing if the check fails.Changes proposed in this request:
/openurl <s>/gameui_open_link <s>/setclipboard <s>The UI and clipboard parts of this pull request are not necessary and can be removed if desired.
It's probably also important to note that no parts of the game's UI actually use these commands yet, they just exist in the console for now :)