chore(platform): park registry-platform-sts#334
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce0ed213e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Parked until Assisted Access or the delegation profile work supplies a | ||
| # release-surface consumer (#298). Keep the source in git, but out of | ||
| # workspace CI. | ||
| "crates/registry-platform-sts", |
There was a problem hiding this comment.
Putting crates/registry-platform-sts in exclude makes it stop having a workspace root, but its own manifest still inherits version.workspace, edition.workspace, and dependency versions from that root. In the contexts that still build it—products/platform/fuzz/Cargo.toml depends on it for .github/workflows/nightly-security.yml's platform-fuzz sts_subject_token target, and lab/scripts/commons-check.sh still passes -p registry-platform-sts—Cargo now fails before compilation (failed to find a workspace root / cannot specify features for packages outside of workspace). Please either make the parked crate self-contained or remove/update these callers when excluding it.
Useful? React with 👍 / 👎.
| enforcement, Notary disclosure policy evaluation. `registry-platform-sts` | ||
| is parked outside the workspace until a consumer is promoted (#298). |
There was a problem hiding this comment.
This parks STS outside the 1.0 adversarial scope, but the release evidence used by the next checklist item still treats STS as active coverage: release/notes/negative-path-coverage-map.md points NP-02, NP-13, and NP-23 at crates/registry-platform-sts tests and even marks NP-13 as covered partly on that basis. In a release-readiness review after this change, those rows overstate negative-path coverage for code that is explicitly not a workspace member or release artifact, so the STS anchors need to be removed or marked parked/deferred with replacement product evidence.
Useful? React with 👍 / 👎.
1 participant
Summary
Parks
registry-platform-stsoutside the active Cargo workspace until it has a promoted release-surface consumer, as tracked by #298.Why
The crate has no in-workspace consumer and should not remain a 1.0 workspace CI, release, or adversarial-review surface until Assisted Access, delegation-profile work, or another product promotes a concrete consumer.
Impact
STS source remains available for later reactivation. It is no longer built by default as part of workspace CI or represented as an active load-bearing platform crate.
Validation
cargo metadata --locked --format-version 1 --no-deps(confirmed STS is absent from workspace members)cargo fmt --checkcargo check --locked --workspace --all-targetscargo test --locked --workspace