[cling] Desugar UsingType in GetFullyQualifiedType#22742
Conversation
The change in getFullyQualifiedType() in the commit llvm/llvm-project@af27466 added explicit desugaring of UsingType: ``` if (isa<UsingType>(QT.getTypePtr())) { return getFullyQualifiedType(QT.getSingleStepDesugaredType(Ctx), Ctx, WithGlobalNsPrefix); } ``` This has been there since LLVM14 and we could disentagle this from the upgrade to LLVM22. This will cause `SG::sgkey_t` to be resolved to its underlying type `uint32_t` when GetFullTypeName() is called, rather than preserving the typedef alias name as before.
Test Results 23 files 23 suites 3d 15h 3m 5s ⏱️ For more details on these failures, see this check. Results for commit 0abc723. ♻️ This comment has been updated with latest results. |
|
Is this is what we really want? I am not sure if we should be losing that type sugar but @pcanal should be able to tell... |
|
This is what upstream does. We maintain a separate |
Yes, I agree with that, let's see what @pcanal has to say if that's not breaking something in i/o conceptually. |
The change in getFullyQualifiedType() in the commit llvm/llvm-project@af27466 added explicit desugaring of UsingType:
This has been there since LLVM14 and we could disentagle this from the upgrade to LLVM22.
This will cause
SG::sgkey_tto be resolved to its underlying typeuint32_twhen GetFullTypeName() is called, rather than preserving the typedef alias name as before.This test was added in: #19615, should fix: #12698
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #