[tmva][sofie] Translate PyTorch parser to Python#22763
Merged
Merged
Conversation
Test Results 23 files 23 suites 3d 17h 48m 44s ⏱️ For more details on these failures, see this check. Results for commit 8be06b4. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
pytorch_parser
branch
2 times, most recently
from
5b33960 to
563100a
Compare
guitargeek
requested review from
bellenot,
couet,
dpiparo,
lmoneta and
vepadulano
as code owners
Python is a natural choice for this tutorial, becuase if the user already trained a model with PyTorch in Python, it makes sense to also do the model parsing from SOFIE to Python. That's why we're also planning to remote the C++ entry point to the PyTorch parser in the future. 🤖 Done with the help of AI.
Implementing the PyTorch parser directly in Python is easier and less error prone than using the C Python API from C++. 🤖 Done with the help of AI.
guitargeek
force-pushed
the
pytorch_parser
branch
from
563100a to
8be06b4
Compare
lmoneta
reviewed
Jul 9, 2026
lmoneta
left a comment
lmoneta
left a comment
Member
There was a problem hiding this comment.
LGTM!
Thank you Jonas for move the PyTorch parser from C++ to Python
lmoneta
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the PyTorch parser directly in Python is easier and less error prone than using the C Python API from C++.
🤖 Done with the help of AI.