[core] fix UUID test#22773
Open
jblomer wants to merge 1 commit into
Open
Conversation
Test Results 23 files 23 suites 3d 11h 44m 57s ⏱️ For more details on these failures, see this check. Results for commit db27e02. |
silverweed
reviewed
Jul 8, 2026
|
|
||
| TUUID u; | ||
| EXPECT_EQ('1', u.AsString()[14]); | ||
| EXPECT_TRUE(u.AsString()[14] == '1' || u.AsString()[14] == '3'); |
Contributor
There was a problem hiding this comment.
What's the meaning of this check in general? (both before and after the change)
Contributor
Author
There was a problem hiding this comment.
This is the position that encodes the UUID version. The "classic" TUUID produces either a version 1 or a version 3 UUID, depending on the platform several other factors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.