Skip to content

test: use shared test utilities#36

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/use-test-utils
Jul 13, 2026
Merged

test: use shared test utilities#36
chenjiahan merged 3 commits into
mainfrom
chenjiahan/use-test-utils

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

This PR adopts @rstackjs/test-utils v0.2.0 to remove duplicated file, logging, polling, and port helper implementations from the Rstack CLI tests. It also adds a test-local prepareDist fixture and a thin logHelper extension with expectBuildEnd(), following Rsbuild's fixture APIs while keeping repository-specific behavior under #test-helpers.

Related Links

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 45312e3c-b99d-4183-a90f-886f1160b1fc

📥 Commits

Reviewing files that changed from the base of the PR and between d5c5598 and f6ac23c.

📒 Files selected for processing (4)
  • packages/rstack/test/config/reload-app-config/index.test.ts
  • packages/rstack/test/helpers/cliTest.ts
  • packages/rstack/test/helpers/index.ts
  • packages/rstack/test/helpers/logs.ts
📝 Walkthrough

Walkthrough

The change adds @rstackjs/test-utils to the workspace catalog and package development dependencies. Rstack test helpers now use shared logging, file, port, and distribution-preparation utilities. A prepareDist fixture is added to the CLI test fixtures. Configuration and CLI tests use prepared output directories, while reload tests use file-waiting and log assertions.solete local helper exports and the BUILD_END_LOG constant are removed.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title succinctly reflects the main change: switching tests to shared utilities.
Description check ✅ Passed The description matches the changeset by describing the shared test-utils migration and new fixtures.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/use-test-utils

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan merged commit b29c4d7 into main Jul 13, 2026
3 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/use-test-utils branch July 13, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant