Remove explicit creation of sig file, gnupload script handles that#1008
Merged
Conversation
* Makefile (package): Depend on tar-file. (release): Remove targets not needed. (git-pull): Make check robust for current state on the workfolder. (git-tag-release): (ftp): Add confirm check for these potential dangerous targets. ($(pkg_parent)/hyperbole-$(HYPB_VERSION).tar.gz): Add dependency on tar file. ($(pkg_parent)/hyperbole-$(HYPB_VERSION).tar.sig): Remove target. gnupload script handles the sig file. (packageclean): Simplify cleanup by removing whole package build directory. (GNUFTP): Add --dry-run during for now while testing.
rswgnu
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
(release): Remove targets not needed.
(git-pull): Make check robust for current state on the workfolder.
(git-tag-release):
(ftp): Add confirm check for these potential dangerous targets.
(
tar file.
(
target. gnupload script handles the sig file.
(packageclean): Simplify cleanup by removing whole package build
directory.
(GNUFTP): Add --dry-run during for now while testing.
Why
gpg signature is not needed. gnupload script handles that and we can
skip that step.
While at it some unused or not needed parts of the Makefile was
removed.
Safety confirmations steps where added to the git-tag-relase and ftp
target as they could cause issues if executed by mistake.
In this first PR the --dry-run option is set on gnupload script as
well as an extra precaution to allow testing of the ftp target.
Note
When we do the release it would be good to do that together so we can
fix any issues. But it should now be possible for testing purposes to
run things like: