Clippy fixes#642
Open
ratmice wants to merge 4 commits into
Open
Conversation
The code after running `cargo clippy --fix` seems to require this change, The suggestions and code modifications introduce a borrow checker error. Clippy changes a return statement from `return Err(...);`, to `Err(...)?;`. However the borrow checker can tell `return Err(...)` can't fall through. But after the change the compiler isn't smart enough to infer that `Err(...)?;` can't fall through because it can never be an `Ok` value.
Collaborator
Author
|
Perhaps rather than adding the trait impl, instead I should put more effort into rewriting the code block? Maybe a Edit: That will work, but it is a 200+ line I went ahead and pushed that, happy to back it out though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first patch is hand written, so that the subsequent
cargo clippy --fixwon't introduce compilation errors with the borrow checker.