Skip to content

fix: 현재 학기 지원대학 없음 문구 수정#606

Merged
manNomi merged 1 commit into
mainfrom
fix/current-term-empty-universities
Jul 14, 2026
Merged

fix: 현재 학기 지원대학 없음 문구 수정#606
manNomi merged 1 commit into
mainfrom
fix/current-term-empty-universities

Conversation

@manNomi

@manNomi manNomi commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

관련 이슈

  • 없음

작업 내용

  • 대학 목록 원본 데이터가 없을 때 검색 결과가 없습니다 대신 현재 학기 지원대학이 없습니다로 표시되도록 수정했습니다.
  • 검색어/필터 적용 결과가 없을 때는 기존 검색 결과 없음 문구를 유지하도록 빈 상태를 분리했습니다.

검증

  • pnpm --filter @solid-connect/university-web run lint:check
  • pnpm --filter @solid-connect/university-web run typecheck:ci
  • push hook의 @solid-connect/university-web CI parity checks 통과

특이 사항

  • 실제 대학 데이터가 없는 상태와 검색/필터 결과가 없는 상태의 문구만 분리했습니다.

리뷰 요구사항 (선택)

  • 현재 학기 모집 대학이 없는 경우의 빈 상태 문구가 의도와 맞는지 확인 부탁드립니다.

@manNomi manNomi requested a review from wibaek as a code owner July 13, 2026 15:47
@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jul 13, 2026 3:48pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jul 13, 2026 3:48pm
solid-connection-web Skipped Skipped Jul 13, 2026 3:48pm

@github-actions github-actions Bot added the university Changes in apps/university-web label Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 28555462-4650-4e65-b711-45c8f4f517d2

📥 Commits

Reviewing files that changed from the base of the PR and between fe3aaa8 and 7acf883.

📒 Files selected for processing (1)
  • apps/university-web/src/app/university/[homeUniversity]/_ui/UniversityListContent.tsx

Walkthrough

  1. 빈 상태 컴포넌트 정의
    • 현재 학기 지원대학 없음과 검색 결과 없음 UI를 পৃথ পৃথক 컴포넌트로 추가했습니다.
  2. 상태별 렌더링 분기
    • 프리렌더 폴백과 실제 목록 영역에서 전체 대학 목록과 필터 결과를 পৃথ পৃথক하게 판단하도록 변경했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: wibaek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 제목이 현재 학기 지원대학 없음 문구 수정이라는 핵심 변경을 정확히 요약합니다.
Description check ✅ Passed 관련 이슈, 작업 내용, 검증, 특이 사항, 리뷰 요구사항이 모두 있어 템플릿을 대체로 충족합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/current-term-empty-universities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@manNomi manNomi merged commit 7af887a into main Jul 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

university Changes in apps/university-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant