feat: 스카이스캐너형 데스크톱 레이아웃 적용#607
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 745dd7a421
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > | ||
| <IconCloud /> | ||
| </Link> | ||
| <nav className="sticky top-0 z-40 hidden h-[72px] border-b border-k-100 bg-white md:block" aria-label="주요 메뉴"> |
There was a problem hiding this comment.
Add anchor offset for sticky desktop nav
With this new 72px sticky desktop header, in-page anchors can now land underneath the nav. For example, the desktop Terms TOC links to sections that still only use scroll-mt-8 in TermsSectionList, so clicking a 목차 item positions the section title inside the header area instead of below it. Please add a desktop scroll margin/offset that accounts for the new header height.
Useful? React with 👍 / 👎.
관련 이슈
작업 내용
DESIGN.md와 동기화 설정을 추가했습니다.apps/web의 전체 사용자 화면을 1280px 중심 레이아웃과 작업별 보조 패널 구조로 정리했습니다.apps/university-web의 모든 페이지 템플릿에도 같은 1280px 작업 무대와 고정 보조 패널 간격을 적용했습니다.Web 데스크톱 전체 화면
Web 모바일 회귀 검수
University 데스크톱 전체 템플릿
University 모바일 회귀 검수
특이 사항
검증
pnpm --filter @solid-connect/web run ci:checkpnpm --filter @solid-connect/university-web run ci:check1440x1000), 모바일 3개 route state (390x844)리뷰 요구사항 (선택)