fix: SolidStart v2 routing: sidebar and inline links#1570
Merged
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@tknkaa Thank you for your PR working on this. Similar to the previous PR, can you please add back in the PR template and indicate whether you've read the contributing guidelines? |
Contributor
Author
|
@LadyBluenotes |
LadyBluenotes
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
Three routing bugs affecting the SolidStart v2 documentation:
start, latestsidebar was built without a filter, causing thev2/subdirectory to appear as a collapsible "V2" section in the Latest SolidStart navigation.start, v2sidebar was registered under the wrong key (/v2/solid-startinstead of/solid-start/v2), producing broken prev/next navigation links on v2 pages./v2/solid-start/...instead of/solid-start/v2/...), resulting in 404s.Related issues & labels