fix(cdk): reference existing GitHub OIDC provider via fromAccount#735
Merged
Conversation
aws-cdk-github-oidc v4 switched GithubActionsIdentityProvider from a
Lambda-backed custom resource (Custom::AWSCDKOpenIdConnectProvider) to the
native AWS::IAM::OIDCProvider. Reusing the same logical id across that type
change made CloudFormation reject the change set ("Update of resource type is
not permitted").
The provider is an account-level singleton, so reference the existing one with
fromAccount instead of managing it in this stack. Migration was done in two
deploys: first retaining the v2 custom resource's physical provider, then
removing it here so the retained provider survives and UploadRole's trust
policy points at the existing provider ARN.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-cdk-github-oidc v4 switched GithubActionsIdentityProvider from a
Lambda-backed custom resource (Custom::AWSCDKOpenIdConnectProvider) to the
native AWS::IAM::OIDCProvider. Reusing the same logical id across that type
change made CloudFormation reject the change set ("Update of resource type is
not permitted").
The provider is an account-level singleton, so reference the existing one with
fromAccount instead of managing it in this stack. Migration was done in two
deploys: first retaining the v2 custom resource's physical provider, then
removing it here so the retained provider survives and UploadRole's trust
policy points at the existing provider ARN.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com