Skip to content

chore(tests): improve ut coverage for rate_limit configuration #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Molter73 merged 1 commit into from
Jul 15, 2026
+35 −3
Merged

chore(tests): improve ut coverage for rate_limit configuration #1113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions fact/src/config/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ fn parsing() {
inodes_max: 64
hotreload: false
scan_interval: 60
rate_limit: 50000
"#,
FactConfig {
paths: Some(vec![PathBuf::from("/etc")]),
Expand Down Expand Up @@ -449,7 +450,7 @@ fn parsing() {
},
hotreload: Some(false),
scan_interval: Some(Duration::from_secs(60)),
rate_limit: None,
rate_limit: Some(50000),
},
),
];
Expand Down Expand Up @@ -780,6 +781,15 @@ paths:
"scan_interval: -128.5",
"invalid scan_interval: Real(\"-128.5\")",
),
(
"rate_limit: true",
"rate_limit field has incorrect type: Boolean(true)",
),
(
"rate_limit: 1000.0",
"rate_limit field has incorrect type: Real(\"1000.0\")",
),
("rate_limit: -1000", "invalid rate_limit: -1000"),
("unknown:", "Invalid field 'unknown' with value: Null"),
];
for (input, expected) in tests {
Expand Down Expand Up @@ -1571,6 +1581,25 @@ fn update() {
..Default::default()
},
),
(
"rate_limit: 1000",
FactConfig::default(),
FactConfig {
rate_limit: Some(1000),
..Default::default()
},
),
(
"rate_limit: 1000",
FactConfig {
rate_limit: Some(50000),
..Default::default()
},
FactConfig {
rate_limit: Some(1000),
..Default::default()
},
),
(
r#"
paths:
Expand All @@ -1597,6 +1626,7 @@ fn update() {
inodes_max: 8192
hotreload: false
scan_interval: 60
rate_limit: 1000
"#,
FactConfig {
paths: Some(vec![PathBuf::from("/etc"), PathBuf::from("/bin")]),
Expand Down Expand Up @@ -1627,7 +1657,7 @@ fn update() {
},
hotreload: Some(true),
scan_interval: Some(Duration::from_secs(30)),
rate_limit: None,
rate_limit: Some(5000),
},
FactConfig {
paths: Some(vec![PathBuf::from("/etc")]),
Expand Down Expand Up @@ -1658,7 +1688,7 @@ fn update() {
},
hotreload: Some(false),
scan_interval: Some(Duration::from_secs(60)),
rate_limit: None,
rate_limit: Some(1000),
},
),
];
Expand Down Expand Up @@ -1696,6 +1726,8 @@ fn defaults() {
assert_eq!(config.grpc.backoff.multiplier(), 1.5);
assert_eq!(config.grpc.backoff.retries(), 10);
assert_eq!(config.otel.endpoint(), None);
assert_eq!(config.scan_interval(), Duration::from_secs(30));
assert_eq!(config.rate_limit(), 0);
}

static ENV_MUTEX: Mutex<()> = Mutex::new(());
Expand Down
Loading