Skip to content

Add STM32C5 support to I3C with dual HAL V1/V2 compatibility#3023

Open
Aymane-ST wants to merge 2 commits into
stm32duino:mainfrom
Aymane-ST:c5_i3C_support
Open

Add STM32C5 support to I3C with dual HAL V1/V2 compatibility#3023
Aymane-ST wants to merge 2 commits into
stm32duino:mainfrom
Aymane-ST:c5_i3C_support

Conversation

@Aymane-ST

@Aymane-ST Aymane-ST commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This PR adds dual HAL V1 / HAL V2 support to the I3C library while preserving the existing public API as much as possible.

  • the implementation keeps V1 and V2 paths explicit with local #if defined(USE_HALV2_DRIVER) blocks
  • existing behavior and public API were preserved whenever possible
  • a few internal/public helper types were introduced where needed to avoid exposing HAL-specific structures in examples

@Aymane-ST Aymane-ST added this to the 3.0.0 milestone Jul 15, 2026
@Aymane-ST
Aymane-ST requested a review from fpistm July 15, 2026 12:21
@Aymane-ST Aymane-ST self-assigned this Jul 15, 2026
@Aymane-ST Aymane-ST added enhancement New feature or request fix 🩹 Bug fix labels Jul 15, 2026
@fpistm fpistm removed the fix 🩹 Bug fix label Jul 15, 2026
@Aymane-ST Aymane-ST changed the title Add STM32C5 support with dual HAL V1/V2 compatibility Add STM32C5 support to I3C with dual HAL V1/V2 compatibility Jul 15, 2026
fpistm
fpistm requested changes Jul 15, 2026
View reviewed changes

@fpistm fpistm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round.

Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/examples/Controller_Target/TargetReceive/TargetReceive.ino Outdated
Comment thread libraries/SrcWrapper/src/HAL/stm32yyxx_util_i3c.c Outdated
Comment thread libraries/I3C/src/I3C_I2C.cpp Outdated
@github-project-automation github-project-automation Bot moved this from In progress to Needs review in STM32duino libraries Jul 15, 2026
@Aymane-ST
Aymane-ST force-pushed the c5_i3C_support branch 3 times, most recently from 94853b6 to 0a3558e Compare July 16, 2026 08:25
@fpistm fpistm mentioned this pull request Jul 16, 2026
Merged
16 tasks
@fpistm
fpistm marked this pull request as ready for review July 16, 2026 13:33
fpistm
fpistm requested changes Jul 16, 2026
View reviewed changes
Comment thread libraries/I3C/examples/Controller_Target/TargetReceive/TargetReceive.ino Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.h Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp Outdated
Comment thread libraries/I3C/src/I3C.cpp
Comment thread libraries/I3C/src/I3C.cpp Outdated
Aymane-ST added 2 commits July 17, 2026 17:09
@Aymane-ST
Revert "chore(i3c): disable for HALv2 support"
0dbe08b 
This reverts commit b509e77.
@Aymane-ST
feat(I3C): add dual HAL V1/V2 support
638af74 
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm requested changes

Assignees

@Aymane-ST Aymane-ST

Labels

enhancement New feature or request

Projects

STM32duino libraries
Status: Needs review

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Aymane-ST @fpistm