refactor(plugins): pin anthropic to 1.48, drop redundant colon check, trim docs#77
Merged
Merged
Conversation
… trim docs - pin anthropic extra to strands-agents>=1.48.0 for parity with base/other extras - remove redundant ':' check in resolve_plugin/resolve_hook; load_object already raises ImportResolutionError (a ValueError subclass) on malformed specs - trim Chapter 19 skill-authoring duplication to a pointer at the strands/Agent Skills docs; lighten the params-path (CWD-relative) note - fix project-map stack-note typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @galuszkm 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Follow-up review fixups for #75, targeting the PR branch so it merges straight in.
Changes
anthropicextra tostrands-agents>=1.48.0(was left at1.35.0while base + ollama/openai/gemini moved to 1.48.0), inpyproject.tomlanduv.lock.':' not in typecheck fromresolve_pluginandresolve_hook.load_objectalready raisesImportResolutionError(aValueErrorsubclass) on a malformed spec, so behaviour and the existing tests (which match on"import spec") are unchanged; docstrings updated accordingly.paramspath note and flag it may change in a future release; update the error table (missing:now flows throughload_object).project-map.mdstack-note (gemini.anthropic. →gemini,anthropic).Testing
uv run just check— clean (ruff format + lint, ty, bandit).uv run just test— 232 passed, 76.46% coverage.Note: opened as a delta against
feat/mg/pluginsbecause the sandbox gateway could not fast-forward the PR branch directly. Merging this intofeat/mg/pluginsupdates #75.