Skip to content

refactor(plugins): pin anthropic to 1.48, drop redundant colon check, trim docs#77

Merged
galuszkm merged 2 commits into
feat/mg/pluginsfrom
feat/mg/plugins-review-fixups
Jul 22, 2026
Merged

refactor(plugins): pin anthropic to 1.48, drop redundant colon check, trim docs#77
galuszkm merged 2 commits into
feat/mg/pluginsfrom
feat/mg/plugins-review-fixups

Conversation

@kiro-agent

@kiro-agent kiro-agent Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request was created by @kiro-agent on behalf of @galuszkm 👻

Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web


Follow-up review fixups for #75, targeting the PR branch so it merges straight in.

Changes

  • Dependency parity — pin the anthropic extra to strands-agents>=1.48.0 (was left at 1.35.0 while base + ollama/openai/gemini moved to 1.48.0), in pyproject.toml and uv.lock.
  • Thinner resolvers — drop the redundant ':' not in type check from resolve_plugin and resolve_hook. load_object already raises ImportResolutionError (a ValueError subclass) on a malformed spec, so behaviour and the existing tests (which match on "import spec") are unchanged; docstrings updated accordingly.
  • Docs — trim Chapter 19's duplicated SKILL.md authoring deep-dive down to a pointer at the strands / Agent Skills docs (that content is owned by strands, not strands-compose); lighten the params path note and flag it may change in a future release; update the error table (missing : now flows through load_object).
  • Typo — fix the project-map.md stack-note (gemini. anthropic. → gemini, anthropic).

Testing

  • uv run just check — clean (ruff format + lint, ty, bandit).
  • uv run just test — 232 passed, 76.46% coverage.

Note: opened as a delta against feat/mg/plugins because the sandbox gateway could not fast-forward the PR branch directly. Merging this into feat/mg/plugins updates #75.

… trim docs

- pin anthropic extra to strands-agents>=1.48.0 for parity with base/other extras
- remove redundant ':' check in resolve_plugin/resolve_hook; load_object already
  raises ImportResolutionError (a ValueError subclass) on malformed specs
- trim Chapter 19 skill-authoring duplication to a pointer at the strands/Agent
  Skills docs; lighten the params-path (CWD-relative) note
- fix project-map stack-note typo

@galuszkm galuszkm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@galuszkm
galuszkm merged commit 36bb5a9 into feat/mg/plugins Jul 22, 2026
@galuszkm
galuszkm deleted the feat/mg/plugins-review-fixups branch July 22, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants