feat: add has function to createContext#18472
Open
soleuniverse101 wants to merge 5 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 6d5508d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is about #18471.
I hope it's okay, I went ahead and implemented this before having an answer on the issue about if this is okay as a feature. If it's not, I understand if this PR has to be closed, it was pretty quick to do.
If this PR is accepted, I have a few comments :
createContextshould still work by disregarding the third function of the now triplet returned.[get, set]pair by a[get, set, has]triplet to reflect the new API so that people can notice the existence of the newhasfunction. I was wondering if this was too much noise since people should probably mainly useget/set, while the use ofhaswould be more rare.runtime-runes/samples/create-contextandruntime-runes/samples/create-context-programmatictests. Is this okay or should I add new separate tests ?createContextmentionssince 5.40.0. I'm not sure if I should update that or not, given that while the function was introducted at that version, this new signature would be more recent. How should I proceed ?PS : sorry for the length of this body
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint