fix: preserve CSS comments when printing an AST#18475
Open
manuel3108 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 9d01b8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was identified by sveltejs/cli#1138.
CSS comments were discarded by the parser, so print(parse(source)) could not reproduce them. This adds CSS comment nodes to the public AST and preserves inline comments through raw values, allowing the printer to retain them.
Although this extends public AST child unions, I don’t think it should be considered breaking. print has existed for roughly seven months without anyone reporting this limitation, and adding a previously missing node type is a corrective AST change rather than removing or changing existing nodes.
The implementation is more intrusive than I would have liked, particularly because CSS analysis must now ignore comment children. I’m open to less invasive alternatives.
Alternatives considered
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint