fix: match qr detail button with design#635
Open
jvsena42 wants to merge 1 commit into
Open
Conversation
jvsena42
marked this pull request as draft
July 17, 2026 12:33
Greptile SummaryThis PR updates the Receive screen’s QR and details toggle to match the intended design.
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| Bitkit/Views/Wallets/Receive/ReceiveQr.swift | Adds explicit button designs for the QR and details states while preserving toggle behavior and onboarding precedence. |
| changelog.d/next/635.fixed.md | Documents the Receive screen toggle design update. |
Reviews (2): Last reviewed commit: "fix: match details button with design" | Re-trigger Greptile
jvsena42
marked this pull request as ready for review
July 17, 2026 12:38
jvsena42
enabled auto-merge
July 17, 2026 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the QR/details toggle on the Receive screen to match the design, so the two states no longer look identical.
Description
Both states reuse the existing QR icon asset and the existing "Show QR Code" string, so no new assets or translation keys were needed. This brings iOS in line with the equivalent Android implementation, which already uses a tertiary button for details and a primary button with a QR icon for the QR state.
Linked Issues/Tasks
Designs:
Related Android:
ReceiveQrScreen.ktalready implements the same two variants.Screenshot / Video
no-channel.mov
with-channel.mov
QA Notes
Manual Tests
regression:Spending tab with no channels → button still reads Receive Lightning Funds as a primary with the purple bolt icon.regression:Tap it: nav to Receive CJIT Amount as before.regression:While the node is still starting: the button stays disabled.regression:E2E identifiers still resolve, with QRCode on the details state and ShowDetails on the QR state.Automated Checks
validate-translations.jspasses with 0 errors.