feat(wallet): maintain derived-account rolling lookahead#93
Open
ben-kaufman wants to merge 2 commits into
Open
feat(wallet): maintain derived-account rolling lookahead#93ben-kaufman wants to merge 2 commits into
ben-kaufman wants to merge 2 commits into
Conversation
054698f to
b8c959c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.7.0-rc.56and regenerate the native binding artifactsMotivation
An exported xpub may issue receive addresses independently of the node. After the initial full scan, incremental sync previously covered only scripts already revealed to BDK, so later activity at a higher remote-derived index could remain undiscovered until the account was reconstructed.
Derived accounts now scan a rolling window beyond their highest revealed receive index. Activity inside that window advances and replenishes it without revealing unused addresses.
reveal_receive_addresses_to_accountremains available when an external issuer may skip beyond the current lookahead.Stacking
This PR is stacked on #92 (
codex/derived-account-lifecycle-parity). It should be retargeted tomainafter #92 merges.Verification
cargo fmt --checkgit diff --checkcargo test --offline -p bdk-wallet-aggregate(38 passed)cargo clippy --offline -p bdk-wallet-aggregate --all-targets -- -D warningscargo test --offline --lib(75 passed)cargo test --offline --features uniffi --lib(85 passed)cargo check --offline --all-targets --all-features./bindgen.sh, including JVM build, Android Maven-local publish, native-symbol checks, and 16 KiB alignment checksPackage.swift:91a31d12acc142ffaa405f4cae8eda0a414f71cf3bd0c4ef26b420a741483617cargo test --offline --docpasses 11 of 12 doctests. The unchangedNode::list_payments_with_filterexample fails at runtime withWalletSetupFailed; this is inherited from the #92 base and is outside this PR's diff.Release