ui: remove the shared Banner method (no intro banner on any command)

[LukasWodka]

What

The follow-up to #370: removes the intro banner from every remaining command and deletes the shared ui.Printer.Banner method so it can't come back.

The banner block —

  tracebloc
  ────────────────────────────────────────
  <subtitle>

— was a single shared method called by 7 commands. #370 removed it from the data commands; the doctor redesign dropped it from doctor. This PR removes the last three callers (cluster info, resources, resources set) and deletes the method itself.

Why now

Verified the follow-up is unblocked: doctor already de-bannered on develop; the resources redesign (#359) merged its new view but left the banner; PR #361 (which would have removed it) is closed; and the only open PR touching these areas (#369) is scoped to doctor.go — no collision.

Spacing

Every command still opens with exactly one blank line:

• cluster info — first line is a Section, which supplies its own leading blank → just remove the banner.
• resources (show) — first line is a Stat (no leading newline) → replace the banner with Newline().
• resources set — the no-op and phantom-GPU messages are message-led → add Newline() to each; the Section/dry-run paths supply their own, so I also dropped a now-redundant Newline() in the dry-run path (it was double-blanking once the banner was gone).

Verified live against a k3d env (resources, cluster info, resources set --dry-run for both the no-op and change paths) — all open with a single clean blank line.

Changed

• internal/ui/ui.go — delete Banner; fix the package doc + Para comment that referenced it.
• internal/cli/cluster.go, resources.go, resources_set.go — drop the banner calls (+ spacing as above).
• internal/ui/ui_test.go — drop the Banner call + its "tracebloc" assertion (the method no longer exists).
• internal/cli/cluster_info_test.go — the test asserted the "cluster diagnostics" subtitle; now asserts the Kubeconfig section (test-ctx) instead.
• internal/cli/data_delete_json_test.go — stale "banner" comment → "output".

Test plan

• go build ./..., go vet, gofmt — clean.
• go test ./... — all pass.
• Grepped the tree: zero references to the UI Banner remain (the internal/submit "banner" hits are the ingestor's 📊 INGESTION SUMMARY banner — unrelated).

🤖 Generated with Claude Code

---

Note

Low Risk
CLI presentation and test-only seams only; no auth, cluster mutation, or API behavior changes.

Overview
Removes the shared ui.Printer.Banner helper and the last CLI callers (cluster info, resources show, resources set), completing the de-banner work after earlier commands dropped it.

Spacing: resources show starts with Newline() instead of a banner; no-op / phantom-GPU messages in resources set add Newline() where needed; the confirm path drops an extra Newline() before PromptHint so output does not double-blank; dry-run drops a redundant Newline() before Section. runResourcesShow uses the resolveClusterTargetFn seam for tests.

Tests: Expectations move off banner subtitles (e.g. cluster info checks test-ctx); new tests pin a single leading blank for show and set confirm after #375.

^{Reviewed by Cursor Bugbot for commit 5c24c7b. Bugbot is set up for automated code reviews on this repo. Configure here.}

[LukasWodka]

👋 Heads-up — Code review queue is at 31 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

• averaging-service#204 — chore(release): promote staging → main (week of 2026-07-20) · author: @aptracebloc · no reviewer assigned
• backend#1131 — perf(psr): offload pause/stop edge notify to Celery (#980) · author: @aptracebloc · reviewer: @saqlainsyed007
• backend#1134 — perf(landing): bulk submission counts + team-member fold (#978 pt5 steps 2-3) · author: @aptracebloc · no reviewer assigned
• backend#1147 — chore(release): promote staging → master (week of 2026-07-20) · author: @aptracebloc · reviewer: @saadqbal
• backend#1148 — fix(sb): always close the failed client in reply_to_edge (Bugbot #1147) · author: @aptracebloc · reviewer: @saqlainsyed007
• backend#1149 — chore(models): remove dead Company model (superseded by Account) · author: @saqlainsyed007 · reviewer: @saadqbal
• backend#1155 — chore(deps): bump pillow from 12.2.0 to 12.3.0 · author: @dependabot · no reviewer assigned
• backend#1156 — chore(hygiene): dead deps, dev-deps split, .dockerignore, dead app/scripts/templates (#959) · author: @saqlainsyed007 · reviewer: @saadqbal
• cli#366 — docs(rfc): RFC-0003 — dataset storage & offboard hygiene (draft) · author: @LukasWodka · no reviewer assigned
• cli#373 — fix(push): reject image datasets with no "filename" column in dry-run (data ingest: image preflight green-lights a labels.csv with no "filename" column (image_id) → cluster fails at transfer (exit 9) #371) · author: @LukasWodka · no reviewer assigned

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

[LukasWodka]

bugbot run

[LukasWodka]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6afdd70. Configure here.}

[LukasWodka]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 5c24c7b. Configure here.}

[LukasWodka]

/fr-pass — verified live: no intro banner on data, doctor, resources, or --help.