Added controller method that returns not accepted policies by user#1207
Added controller method that returns not accepted policies by user#1207dati18 wants to merge 11 commits into
Conversation
…ed by user Bug: T432337
6ef72d9 to
f2a65e6
Compare
5c104b5 to
cb54707
Compare
4e1f1dd to
6f350a7
Compare
There was a problem hiding this comment.
I think you have accidentally added unwanted changes to this PR. I see changes from #1207 here. ignore
6f350a7 to
db25856
Compare
rosalieper
left a comment
There was a problem hiding this comment.
I am happy with the change 💯
tarrow
left a comment
There was a problem hiding this comment.
I really like a lot of this patch.
The tests are super comprehensive and readable to me.
I liked that you identified that this should be in Routes test.
I'm still a bit sceptical about the query logic which I personally find hard a little harder to parse than the far less efficient first draft but I do agree that performance probably matters here so it's an acceptable tradeoff for me.
I've left a small suggestion for the direction I looked into just for your interest but I don't think we should look further into this.
Summary
PoliciesController.phpwith new endpointgetMissingPoliciesroutes/api.php(new authenticated routeGET v1/policies/missing, handled byPoliciesController@getMissingPolicies)PoliciesControllertest undertests/Http/Controllerswas merged into the route-level file above because they do full http behaviors like auth middleware, URL, JSON request/response, calling endpoints, etc., not isolated controller functionsBug: T432337