Skip to content

Fix example board clock config. Zeroize on error returns.#52

Merged
aidangarske merged 2 commits into
wolfSSL:mainfrom
AlexLanzano:misc-fixes
Jul 10, 2026
Merged

Fix example board clock config. Zeroize on error returns.#52
aidangarske merged 2 commits into
wolfSSL:mainfrom
AlexLanzano:misc-fixes

Conversation

@AlexLanzano

Copy link
Copy Markdown
Member
  • Fix the PLL configuration on the stm32wba example board config to properly output at 100MHz
  • Make sure to zeroize any key/iv data on any failure in the crypto drivers

@AlexLanzano AlexLanzano self-assigned this Jul 9, 2026
Copilot AI review requested due to automatic review settings July 9, 2026 19:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the STM32WBA55 Nucleo example board’s PLL1 settings to reliably produce a 100 MHz SYSCLK, and improves crypto-driver error handling by zeroizing key/IV material in more failure paths.

Changes:

  • Fix PLL1 “N” configuration and document the RM0493 “value-1 encoded” divider/multiplier fields to achieve 100 MHz SYSCLK.
  • Zeroize AES/CRYP peripheral key+IV registers on additional error exits (timeouts and invalid finalize parameters) in STM32WB and STM32N6 crypto drivers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/crypto/stm32wb_aes.c Adds ZeroKeyIv() calls on more AES error paths and cleanup/invalid-finalize returns.
src/crypto/stm32n6_cryp.c Adds ZeroKeyIv() calls when finalize() rejects invalid tag parameters.
boards/stm32wba55cg_nucleo/board.c Adjusts PLL1 N field and improves clocking comment to match encoded register semantics for 100 MHz SYSCLK.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/crypto/stm32wb_aes.c

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aidangarske aidangarske merged commit 86d36e3 into wolfSSL:main Jul 10, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants