Fenrir: socket fixes, wolfssl macro updates, rsa verify fix and cleanup#583
Fenrir: socket fixes, wolfssl macro updates, rsa verify fix and cleanup#583stenslae wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #583
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
Findings: 1
Low (1)
Orphaned exit: label after removing all goto exit statements
File: ESP32/TLS13-wifi_station-server/main/station_example_main.c:1016
Function: tls_smp_server_task
Category: Dead/unreachable code
The PR deleted both goto exit; statements in the accept loop, but the exit: label remains. It is now referenced by nothing, producing an unused-label warning (compile failure under -Werror).
Recommendation: Remove the now-unreferenced exit: label.
Referenced code: ESP32/TLS13-wifi_station-server/main/station_example_main.c:1016-1017 (2 lines)
This review was generated automatically by Fenrir. Findings are non-blocking.
stenslae
force-pushed
the
f-5610-1297-1705-1701
branch
from
d4e4291 to
2ee988c
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #583
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
No new issues found in the changed files. ✅
stenslae
force-pushed
the
f-5610-1297-1705-1701
branch
from
2ee988c to
f4d4399
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #583
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
No new issues found in the changed files. ✅
stenslae
changed the title
…error handling, RSA verification, and cleanups
stenslae
force-pushed
the
f-5610-1297-1705-1701
branch
from
f4d4399 to
f774adb
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #583
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
No new issues found in the changed files. ✅
padelsbach
left a comment
padelsbach
left a comment
There was a problem hiding this comment.
Looks good, just a few minor touch ups requested
| /* Add a terminating character to the generic server message */ | ||
| recvLine[n] = '\0'; | ||
| fputs(recvLine, stdout); | ||
| else { |
There was a problem hiding this comment.
Can we keep the continue from master instead of this else? I think the intent is to keep using the current socket in this case, in case something arrives late.
| /* Set the file descriptor for ssl and connect with ssl variable */ | ||
| wolfSSL_set_fd(ssl, sockfd); | ||
| if (wolfSSL_connect(ssl) != SSL_SUCCESS) { | ||
| err1 = wolfSSL_get_error(ssl, 0); |
There was a problem hiding this comment.
I know it's not part of the fix, but I randomly noticed there are some tabs in this file, and some lines with whitespace only. Can you fix those?
| wolfSSL_free(ssl); | ||
| ssl = NULL; | ||
| close(listenfd); | ||
| cleanup = 0; |
There was a problem hiding this comment.
I think cleanup is no longer used and can be removed
4 participants
Applied Fenrir fixes and audited for similar errors:
closure of stdin ( fd 0 ) during cleanup.
inSz.