Skip to content

[NO QA] Add BrowserStack Automate uploads using 1Password#96100

Merged
roryabraham merged 2 commits into
mainfrom
rory-browserstack-automate-1p
Jul 14, 2026
Merged

[NO QA] Add BrowserStack Automate uploads using 1Password#96100
roryabraham merged 2 commits into
mainfrom
rory-browserstack-automate-1p

Conversation

@roryabraham

@roryabraham roryabraham commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added commands to upload builds to BrowserStack Automate, loading credentials from the BROWSERSTACK_AUTOMATE secure note in the Mobile-Deploy-CI 1Password vault via load-secrets-action instead of a GitHub secret.

Explanation of Change

Adds Android and iOS BrowserStack App Automate upload steps to the deploy workflow. Credentials are loaded from 1Password (op://Mobile-Deploy-CI/BROWSERSTACK_AUTOMATE/notesPlain) using the same load-secrets-action pattern as the Applause upload jobs, so no new GitHub secret provisioning is required.

Supersedes Add upload steps for Android and iOS to BrowserStack Automate.

Fixed Issues

$ #94368
PROPOSAL:

Tests

  1. Merge this PR.
  2. Trigger a staging deploy (or wait for the next one).
  3. Confirm the Upload Android to BrowserStack and Upload iOS to BrowserStack jobs complete successfully.
  4. Verify the Android and iOS builds appear in BrowserStack App Automate.

Offline tests

NO QA

QA Steps

NO QA

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - workflow-only change

Android: mWeb Chrome

N/A - workflow-only change

iOS: Native

N/A - workflow-only change

iOS: mWeb Safari

N/A - workflow-only change

MacOS: Chrome / Safari

N/A - workflow-only change

@roryabraham @cursoragent
Add BrowserStack Automate uploads using 1Password
ce3a018 
Load BROWSERSTACK_AUTOMATE from the Mobile-Deploy-CI vault via
load-secrets-action instead of a GitHub secret, and upload Android
and iOS builds to BrowserStack App Automate during deploy.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham roryabraham mentioned this pull request Jul 14, 2026
Closed
42 tasks
@roryabraham roryabraham marked this pull request as ready for review July 14, 2026 17:22
@roryabraham roryabraham requested a review from a team as a code owner July 14, 2026 17:23
@melvin-bot melvin-bot Bot requested review from jayeshmangwani and removed request for a team July 14, 2026 17:23
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 14, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce3a01831a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/deploy.yml Outdated
@roryabraham @cursoragent
Run App Live upload before loading Automate credentials
94f3be0 
Move 1Password setup after the existing BrowserStack App Live upload
so Automate credential failures cannot block the Live upload path.

Co-authored-by: Cursor <cursoragent@cursor.com>
Julesssss
Julesssss approved these changes Jul 14, 2026
View reviewed changes

@Julesssss Julesssss left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use continue-on-error: true here? Would prefer not to block/delay deploys here, at least for the moment when this isn't a critical part of the workflow.

Or wait, this will be inherited from job level?

@roryabraham

roryabraham commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

yeah, inherited from the job level. going to merge and we'll see if this works!

@roryabraham roryabraham merged commit c8e1eb7 into main Jul 14, 2026
16 of 17 checks passed
@roryabraham roryabraham deleted the rory-browserstack-automate-1p branch July 14, 2026 21:41
@OSBotify

OSBotify commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@Julesssss Julesssss Julesssss approved these changes
@luacmartins luacmartins Awaiting requested review from luacmartins
@jayeshmangwani jayeshmangwani Awaiting requested review from jayeshmangwani

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roryabraham @OSBotify @Julesssss