[NO QA] Add upload steps for Android and iOS to BrowserStack Automate by isagoico · Pull Request #94370 · Expensify/App

isagoico · 2026-06-23T21:21:42Z

Added commands to upload builds to BrowserStack Automate

Explanation of Change

Fixed Issues

$ #94368
PROPOSAL:

Tests

Verify that the builds are uploaded to BrowserStack

Offline tests

NO QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

NO QA

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Added commands to upload builds to BrowserStack Automate

melvin-bot · 2026-06-23T21:21:48Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen · 2026-06-23T21:25:27Z

I think the test steps for this will be something like:

Merge this PR
Check that the releases were uploaded to BrowserStack (something @isagoico will help with)

If it fails, we should be able to check the GH action logs.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1b7f24aac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-23T21:25:57Z

+
+      - name: Upload Android build to BrowserStack Automate
+        if: ${{ fromJSON(env.IS_APP_REPO) }}
+        run: curl -u "$BROWSERSTACK_AUTOMATE" -X POST "https://api-cloud.browserstack.com/app-automate/upload" -F "file=@${{ steps.find-apk.outputs.APK_PATH }}"


Make Automate uploads fail on HTTP errors

When BrowserStack rejects the Automate upload (for example due to missing/invalid credentials, an unsupported file, or another 4xx/5xx response), this step still exits successfully because curl only treats HTTP errors as failures when --fail/--fail-with-body is set (curl --help all: --fail-with-body Fail on HTTP errors but save the body). That lets staging deploys show the Android/iOS BrowserStack upload jobs as green even though no App Automate build was created; please add --fail-with-body or explicitly validate the response for the new Automate upload commands.

Useful? React with 👍 / 👎.

This seems like something we should address

This is actually the same logic we have for the previous step, so it seems fine to leave as is.

I think we want the browserstack upload to be non-blocking

isagoico · 2026-06-24T19:29:30Z

@luacmartins @tgolen with Carlos review (thank you so much), are we good to merge the PR?

luacmartins · 2026-06-24T19:43:13Z

I asked @roryabraham to review as well since he's built most of these workflows.

roryabraham · 2026-06-24T19:45:33Z

+        if: ${{ fromJSON(env.IS_APP_REPO) }}
+        run: curl -u "$BROWSERSTACK_AUTOMATE" -X POST "https://api-cloud.browserstack.com/app-automate/upload" -F "file=@${{ steps.find-apk.outputs.APK_PATH }}"
+        env:
+          BROWSERSTACK_AUTOMATE: ${{ secrets.BROWSERSTACK_AUTOMATE }}


Did someone from ring0 actually provision this repo secret?

No, I was able to create this one with my GH account. I extracted the browserStack key from the Applause service account.

In order for ${{ secrets.BROWSERSTACK_AUTOMATE }} to expand to the token you want it to, it needs to be saved in the Expensify/App repo or Expensify org. Only ring0 has the access needed to do that. We should create an issue and label it ring0 to do that. You’ll then need to encrypt the secret and send it to the ring0 assignee over slack. I can help you if needed :)

isagoico · 2026-07-09T17:16:22Z

@Julesssss @roryabraham @luacmartins Hello all. Apologies for my lack of activity here. After the earthquake in Venezuela these 2 weeks have been intense and my brain is not at it's full capacity.
Is there anything else we should to to merge this PR? or is it good to go?

roryabraham · 2026-07-09T20:00:37Z

@isagoico we need the secrets.BROWSERSTACK_AUTOMATE API token as I mentioned in this comment

roryabraham · 2026-07-09T20:18:37Z

more precise next steps here: https://expensify.slack.com/archives/C9YU7BX5M/p1783628302348739

roryabraham · 2026-07-14T17:22:22Z

Superseded by #96100

Add upload steps for Android and iOS to BrowserStack Automate

d1b7f24

Added commands to upload builds to BrowserStack Automate

isagoico requested a review from a team as a code owner June 23, 2026 21:21

melvin-bot Bot assigned isagoico Jun 23, 2026

melvin-bot Bot requested review from thesahindia and removed request for a team June 23, 2026 21:21

tgolen requested review from Julesssss, luacmartins and roryabraham June 23, 2026 21:23

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

luacmartins reviewed Jun 24, 2026

View reviewed changes

Comment thread .github/workflows/deploy.yml

Comment thread .github/workflows/deploy.yml

luacmartins approved these changes Jun 24, 2026

View reviewed changes

roryabraham reviewed Jun 24, 2026

View reviewed changes

Julesssss approved these changes Jun 29, 2026

View reviewed changes

This was referenced Jul 14, 2026

[NO QA] Add BrowserStack Automate uploads using 1Password #96097

Closed

[NO QA] Add BrowserStack Automate uploads using 1Password #96100

Merged

roryabraham closed this Jul 14, 2026

Uh oh!

Conversation

isagoico commented Jun 23, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 23, 2026

Uh oh!

tgolen commented Jun 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

isagoico commented Jun 24, 2026

Uh oh!

luacmartins commented Jun 24, 2026

Uh oh!

roryabraham Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

isagoico Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

isagoico commented Jul 9, 2026

Uh oh!

roryabraham commented Jul 9, 2026

Uh oh!

roryabraham commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented Jul 9, 2026 •

edited

Loading