Fix: dashboard Customize button inert (modal built before Bootstrap loaded)#6
Merged
Merged
Conversation
…tstrap loaded) The dashboard's inline script runs at parse time (content is at layout line 69), but bootstrap.bundle.js loads in the footer (line 82) — so `new bootstrap.Modal()` ran against an undefined window.bootstrap, modal stayed null, and the click handler was never attached (guarded on `modal`). Create the modal lazily on first click instead, and attach the handler unconditionally. Matches the DOMContentLoaded pattern every other admin modal uses. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard's inline script runs at parse time (content = layout line 69), but
bootstrap.bundle.jsloads in the footer (line 82). Sonew bootstrap.Modal()ran against an undefinedwindow.bootstrap→ modal null → click handler never attached (it was guarded onmodal). Now the modal is created lazily on first click and the handler attaches unconditionally — the same effective timing every other admin modal gets fromDOMContentLoaded.Verified: php lint + JS syntax clean. (The interactive behavior is still browser-only / outside smoke.)
🤖 Generated with Claude Code