Skip to content

Fix: dashboard Customize button inert (modal built before Bootstrap loaded) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebTigers merged 2 commits into from
Jul 17, 2026
Merged

Fix: dashboard Customize button inert (modal built before Bootstrap loaded) #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c42f2
Fix: dashboard Customize button did nothing (modal created before Boo…
WebTigers Jul 17, 2026
6542240
release: v0.13.1-beta
WebTigers Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ All notable changes to **Tiger Core** (`webtigers/tiger-core`). Format follows
[Keep a Changelog](https://keepachangelog.com/); this project uses [SemVer](https://semver.org/)
— while `0.x`, the public API (`@api`) may still shift between minor versions.

## [0.13.1-beta] — 2026-07-17

### Fixed
- **Dashboard "Customize" button did nothing.** The dashboard's inline script runs at parse time, but
Bootstrap's JS loads in the layout footer *after* it — so `new bootstrap.Modal()` was called against an
undefined `window.bootstrap`, leaving the modal null and the click handler unattached. Now the modal is
created lazily on first click (when Bootstrap is loaded), matching how every other admin view does it.

## [0.13.0-beta] — 2026-07-17

### Added
Expand Down
11 changes: 8 additions & 3 deletions core/views/scripts/admin/index.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ $t = function ($s) use ($tr) { return $tr ? $tr->translate($s) : $s; };
// --- Customize: per-user widget visibility (WP "Screen Options" style) ------------------------
var custBtn = document.getElementById('dash-customize');
var modalEl = document.getElementById('dash-customize-modal');
var modal = (window.bootstrap && modalEl) ? new bootstrap.Modal(modalEl) : null;
var modal = null; // created lazily on first click — Bootstrap's JS loads in the layout
// footer, AFTER this inline script, so window.bootstrap isn't defined yet.

function itemById(id) {
var found = null;
Expand Down Expand Up @@ -236,8 +237,12 @@ $t = function ($s) use ($tr) { return $tr ? $tr->translate($s) : $s; };
grid.layout();
}

if (custBtn && modal) {
custBtn.addEventListener('click', function () { buildPrefs(); modal.show(); });
if (custBtn && modalEl) {
custBtn.addEventListener('click', function () {
if (!modal && window.bootstrap) { modal = new bootstrap.Modal(modalEl); }
buildPrefs();
if (modal) { modal.show(); }
});
}
if (modalEl) {
modalEl.addEventListener('change', function (e) {
Expand Down
2 changes: 1 addition & 1 deletion library/Tiger/Version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
class Tiger_Version
{
/** Current Tiger Core version. Keep in lockstep with the git tag cut for a release. */
const VERSION = '0.13.0-beta';
const VERSION = '0.13.1-beta';
}
Loading