ci: skip experimental arduino tests in CI test job#2865
Open
jeff-hykin wants to merge 1 commit into
Open
Conversation
Exclude dimos/experimental/arduino from the pytest collection in the tests job (both the main run and the failure re-run) so the experimental arduino tests don't run on CI. Local pytest is unaffected.
jeff-hykin
requested review from
Dreamsorcerer,
leshy,
paul-nechifor and
spomichter
as code owners
Contributor
Greptile SummaryThis PR narrows which tests run in the CI test job.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "ci: skip experimental arduino tests in C..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2865 +/- ##
==========================================
- Coverage 72.21% 71.81% -0.40%
==========================================
Files 1001 1001
Lines 89755 89755
Branches 8196 8196
==========================================
- Hits 64818 64460 -358
- Misses 22718 23099 +381
+ Partials 2219 2196 -23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
ready-to-merge
jeff-hykin
added
PlzReview
and removed
ready-to-merge
Contributor
|
are we skipping all experimental dirs? @jeff-hykin kind of weird just to hardcode an arduino skip |
Collaborator
|
Yeah, I don't think we want to do this. Seems to have been a lot of confusion in the chats.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
dimos/experimental/arduinofrom CI