Fixes/mustafa/go2 controller benchmark#2874
Open
leshy wants to merge 6 commits into
Open
Conversation
…r-benchmark # Conflicts: # dimos/control/coordinator.py
The benchmarking package is only used by control tasks and the go2 benchmark blueprints, so it lives with the feature instead of the global utils dir.
- import Path the class, not the module, in velocity_profiler - parametrize bare dict/list generics in benchmarking tuning/score - read VelocityProfileDC.min_speed default via class attr, not __dataclass_fields__ (which types as float | MISSING) - cast sentinel-typed configure() kwargs at their use sites - annotate _BENCHMARK_TRANSPORTS with the Blueprint.transports dict type - add K_RETURN/K_BACKSPACE to the pygame stubs
main grew three checks this branch predates: task manifests renamed __registry__.py -> _registry.py, no __all__ in dimos/, and no section marker comments. Rename the two task manifests, drop __all__ from the feature files, and flatten section headers to plain comments.
leshy
requested review from
mustafab0,
paul-nechifor and
spomichter
as code owners
Contributor
Greptile SummaryThis PR adds a Go2 RPP controller and a transport-driven benchmark workflow. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into fixes/mustafa/g..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2874 +/- ##
==========================================
+ Coverage 72.40% 72.46% +0.06%
==========================================
Files 998 1020 +22
Lines 89235 91492 +2257
Branches 8122 8773 +651
==========================================
+ Hits 64610 66304 +1694
- Misses 22427 22916 +489
- Partials 2198 2272 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
ready-to-merge
github-actions
Bot
added
ready-to-merge
mustafab0
approved these changes
Jul 11, 2026
| class VelocityTrackingConfig: | ||
| """Configuration for all three velocity channels.""" | ||
|
|
||
| vx: VelocityPIDConfig = None # type: ignore[assignment] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved utils, mypy fix, merged main