Fix inaccuracies in the Bootstrap 5 migration guide#115
Closed
malberts wants to merge 2 commits into
Closed
Conversation
The container is now a div, not a button: Carousel.php renders `div.carousel-indicators` wrapping `<button>` children where it used to render `ol.carousel-indicators` wrapping `<li>`. The class name itself survives the change, which is the part a CSS author needs, so name both element and class on each side of the mapping. The extension's own stylesheet had to make this exact edit, rewriting `.carousel ol.carousel-indicators` to `.carousel .carousel-indicators`, so the selector shape the row misdirects is one that demonstrably exists in the wild. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The script takes no bare invocation: without --age or --expiredate it exits with "Must specify either --expiredate or --age". Passing --age 0 deletes every object created more than zero seconds ago, and since CacheTime caps each entry's expiry at $wgParserCacheExpireTime, that reaches the whole parser cache. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
malberts
force-pushed
the
pr-114-review-fixes
branch
from
July 16, 2026 21:21
85ec997 to
3bafdae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #114, and is based on that branch so the corrections land with it.
Two claims in the new guide do not match the 6.0.0 source.
Carousel indicators. Only the children became buttons.
Carousel.phprendersdiv.carousel-indicatorswhere it used to renderol.carousel-indicators, so the class survives and the element changes. A reader following the old row rewrites toward a selector that matches nothing. The extension's own stylesheet had to make this exact edit,.carousel ol.carousel-indicatorsto.carousel .carousel-indicators, so the affected selector shape is one that exists in the wild.purgeParserCache. Run bare, the script exits with
Must specify either --expiredate or --age. Passing--age 0deletes every object created more than zero seconds ago, which reaches the whole parser cache becauseCacheTimecaps each entry's expiry at$wgParserCacheExpireTime.