Skip to content

Fix inaccuracies in the Bootstrap 5 migration guide#115

Closed
malberts wants to merge 2 commits into
bs5-migration-guidefrom
pr-114-review-fixes
Closed

Fix inaccuracies in the Bootstrap 5 migration guide#115
malberts wants to merge 2 commits into
bs5-migration-guidefrom
pr-114-review-fixes

Conversation

@malberts

@malberts malberts commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Follows-up to #114, and is based on that branch so the corrections land with it.

Two claims in the new guide do not match the 6.0.0 source.

Carousel indicators. Only the children became buttons. Carousel.php renders div.carousel-indicators where it used to render ol.carousel-indicators, so the class survives and the element changes. A reader following the old row rewrites toward a selector that matches nothing. The extension's own stylesheet had to make this exact edit, .carousel ol.carousel-indicators to .carousel .carousel-indicators, so the affected selector shape is one that exists in the wild.

purgeParserCache. Run bare, the script exits with Must specify either --expiredate or --age. Passing --age 0 deletes every object created more than zero seconds ago, which reaches the whole parser cache because CacheTime caps each entry's expiry at $wgParserCacheExpireTime.

AI-authored — Claude Code, Fable 5 (max); two findings from a local review of #114, picked by @malberts, a third dropped at their call; diff not yet human-reviewed; each claim checked against the 6.0.0 source and MediaWiki 1.43 core, docs only so no tests.

malberts and others added 2 commits July 16, 2026 23:15
The container is now a div, not a button: Carousel.php renders
`div.carousel-indicators` wrapping `<button>` children where it used to
render `ol.carousel-indicators` wrapping `<li>`. The class name itself
survives the change, which is the part a CSS author needs, so name both
element and class on each side of the mapping.

The extension's own stylesheet had to make this exact edit, rewriting
`.carousel ol.carousel-indicators` to `.carousel .carousel-indicators`,
so the selector shape the row misdirects is one that demonstrably
exists in the wild.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The script takes no bare invocation: without --age or --expiredate it
exits with "Must specify either --expiredate or --age". Passing
--age 0 deletes every object created more than zero seconds ago, and
since CacheTime caps each entry's expiry at $wgParserCacheExpireTime,
that reaches the whole parser cache.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant