Skip to content

Fix inaccuracies in the Bootstrap 5 migration guide #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
malberts wants to merge 2 commits into from
Closed

Fix inaccuracies in the Bootstrap 5 migration guide #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d12cd
Map the carousel indicators to what is actually emitted
malberts Jul 16, 2026
3bafdae
Give a purgeParserCache invocation that runs
malberts Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/migration-guide-bs5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ need review. The changes most likely to matter:
| `badge-{color}` | `text-bg-{color}` |
| `badge-pill` | `rounded-pill` |
| `jumbotron` | `p-5 mb-4 bg-body-tertiary rounded-3` |
| carousel indicators as `<ol>`/`<li>` | `<button>` elements |
| `ol.carousel-indicators` with `<li>` children | `div.carousel-indicators` with `<button>` children |

### Hand-written Bootstrap HTML in templates

Expand Down Expand Up @@ -72,7 +72,7 @@ Pages rendered before the upgrade still carry Bootstrap 4 markup in the
parser cache while the wiki already serves Bootstrap 5 CSS and
JavaScript, so components on cached pages can look broken. This
resolves as pages re-render; to force it, purge the affected pages or
run the `purgeParserCache` maintenance script.
run `purgeParserCache.php --age 0` to clear the parser cache.

[BS5-jumbotron]: https://getbootstrap.com/docs/5.3/examples/jumbotron/
[BS5-migration]: https://getbootstrap.com/docs/5.3/migration/